Bug fixes and cleanups#135
Merged
domesticmouse merged 10 commits intogooglemaps:masterfrom Feb 25, 2016
domesticmouse:master
Merged
Bug fixes and cleanups#135domesticmouse merged 10 commits intogooglemaps:masterfrom domesticmouse:master
domesticmouse merged 10 commits intogooglemaps:masterfrom
domesticmouse:master
Conversation
| .destination("paris metro pyramides") | ||
| .mode(TravelMode.TRANSIT) | ||
| .await(); | ||
| assertNotNull(result); |
Contributor
There was a problem hiding this comment.
I know there's not, but I'm really sad there's not a better way to do this.
Well.. actually. You could just...
String localIcon = "";
try {
localIcon = result.routes[0].legs[0].....
} catch (NullPointerException e) {
fail("expected transit...");
}
assertEquals(...);Just my 2c, up to you though.
Contributor
Author
There was a problem hiding this comment.
The long hand approach makes debugging easier. =)
Contributor
There was a problem hiding this comment.
I wouldn't even catch the NPE. JUnit will catch and report the error.
For debugging purposes would it be cleaner to just log the request/response? Or use a breakpoint?
Contributor
Author
There was a problem hiding this comment.
Dropping most of the assertNotNull tests.
Contributor
|
LGTM |
| assertNotNull(response); | ||
| assertNotNull(response.results); | ||
| assertTrue(175 < response.results.length); | ||
| assertTrue(100 < response.results.length); |
Contributor
There was a problem hiding this comment.
What happened to all of the pubs in Sydney? 😨
Contributor
Author
There was a problem hiding this comment.
Late night trading restrictions?
Contributor
Author
|
PTAL @broady |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @samthor && @markmcd