Skip to content

Fix places autocomplete types parameter and introduced correct type enum#140

Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom
springnz:autocomplete-type-fix
Mar 24, 2016
Merged

Fix places autocomplete types parameter and introduced correct type enum#140
domesticmouse merged 1 commit intogooglemaps:masterfrom
springnz:autocomplete-type-fix

Conversation

@mikkelspring
Copy link
Copy Markdown
Contributor

Based on my understanding, the autocomplete for places is slightly different than the places search. In particular, it has a parameter name "types" that takes a restricted set of values.

https://developers.google.com/places/web-service/autocomplete

This PR adjusts the autocomplete to reflect this

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mikkelspring
Copy link
Copy Markdown
Contributor Author

I signed the CLA

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@domesticmouse
Copy link
Copy Markdown
Contributor

I suspect this is a documentation bug, please hold this until I confirm one way or the other.

@domesticmouse domesticmouse merged commit 11c4a14 into googlemaps:master Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants