Add support for the 'permanently_closed' attribute in Place responses.#177
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Sep 6, 2016
Merged
Add support for the 'permanently_closed' attribute in Place responses.#177domesticmouse merged 1 commit intogooglemaps:masterfrom
domesticmouse merged 1 commit intogooglemaps:masterfrom
Conversation
| assertEquals(placeDetails.rating, 4.4, 0.1); | ||
|
|
||
| // Permanently closed: | ||
| assertFalse(placeDetails.permanentlyClosed); |
Contributor
There was a problem hiding this comment.
Can you please add a test that has permanentlyClosed set to true?
Contributor
Author
There was a problem hiding this comment.
@domesticmouse Sure - done and PR updated!
Contributor
|
Thanks! I'll roll a new release in the next couple of weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute is only included in the Places response if the place has shut down. It is not included if the place is still open.