Fix poor resource management code (fixes #179)#181
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Sep 27, 2016
Merged
Fix poor resource management code (fixes #179)#181domesticmouse merged 1 commit intogooglemaps:masterfrom
domesticmouse merged 1 commit intogooglemaps:masterfrom
Conversation
When the response contents are copied the input stream was not being closed. This might appear correct for a one-off tests due to new connections being established. Unfortunately it eventually consumes the entire pool with stuck connections, resulting in no new requests being sent. Cancelling the request isn't enough since the connection is still stuck in a bad state. The simple solution is to close the InputStream, but since OkHttp has a method to do this we'll just delete this bad code entirely.
Contributor
Author
|
This is available on jitpack.io using the coordinates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the response contents are copied the input stream was not being
closed. This might appear correct for a one-off tests due to new
connections being established. Unfortunately it eventually consumes
the entire pool with stuck connections, resulting in no new requests
being sent. Cancelling the request isn't enough since the connection
is still stuck in a bad state.
The simple solution is to close the InputStream, but since OkHttp has
a method to do this we'll just delete this bad code entirely.