Allow specific exception types to be retried or not retried by amyboyd · Pull Request #189 · googlemaps/google-maps-services-java

amyboyd · 2016-10-09T09:51:18Z

PR #168 hasn't been updated in 2 months so it seems to be abandoned. This PR adds basically the same functionality - but this also allows you to customise which exceptions are retries or not.

By default only OverQueryLimitException will be retried. If you don't want to retry after a OverQueryLimitException (maybe you are in time-sensitive situation where you want to fail fast), you can disable retries with toggleifExceptionIsAllowedToRetry(OverQueryLimitException.class, false). The same goes for other exception types.

googlebot · 2016-10-09T09:51:20Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

amyboyd · 2016-10-09T09:54:33Z

The first commit is cherry-picked from #168 - if they haven't done the CLA, I can remove that commit.

The other commits are authored by me.

domesticmouse · 2016-10-11T02:57:32Z

Hey @googlebot, both @amyboyd and @slukes have signed the CLA, near as I can tell. Thanks!

domesticmouse · 2016-10-11T02:59:51Z

src/main/java/com/google/maps/GaeRequestHandler.java


  @Override
-  public <T, R extends ApiResponse<T>> PendingResult<T> handle(String hostName, String url, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries) {
+  public <T, R extends ApiResponse<T>> PendingResult<T> handle(String hostName, String url, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries, ExceptionsAllowedToRetry exceptionsAllowedToRetry) {


This looks like it exceeds the 120 char limit, can you fold it?

domesticmouse · 2016-10-11T03:00:23Z

src/main/java/com/google/maps/GeoApiContext.java

  public interface RequestHandler {
-    <T, R extends ApiResponse<T>> PendingResult<T> handle(String hostName, String url, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries);
-    <T, R extends ApiResponse<T>> PendingResult<T> handlePost(String hostName, String url, String payload, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries);
+    <T, R extends ApiResponse<T>> PendingResult<T> handle(String hostName, String url, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries, ExceptionsAllowedToRetry exceptionsAllowedToRetry);


Please check line length on these two lines.

domesticmouse · 2016-10-11T03:00:58Z

src/main/java/com/google/maps/OkHttpRequestHandler.java


  @Override
-  public <T, R extends ApiResponse<T>> PendingResult<T> handle(String hostName, String url, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries) {
+  public <T, R extends ApiResponse<T>> PendingResult<T> handle(String hostName, String url, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries, ExceptionsAllowedToRetry exceptionsAllowedToRetry) {


Please check line length

domesticmouse · 2016-10-11T03:01:11Z

src/main/java/com/google/maps/OkHttpRequestHandler.java

+
  @Override
-  public <T, R extends ApiResponse<T>> PendingResult<T> handlePost(String hostName, String url, String payload, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries) {
+  public <T, R extends ApiResponse<T>> PendingResult<T> handlePost(String hostName, String url, String payload, String userAgent, Class<R> clazz, FieldNamingPolicy fieldNamingPolicy, long errorTimeout, Integer maxRetries, ExceptionsAllowedToRetry exceptionsAllowedToRetry) {


Line length

domesticmouse · 2016-10-11T03:01:42Z

src/main/java/com/google/maps/internal/ExceptionsAllowedToRetry.java

@@ -0,0 +1,23 @@
+package com.google.maps.internal;


Please add an Apache2.0 copyright header.

domesticmouse

LGTM, Thanks!

Refactor reading test response file into a TestUtils.

3f324a7

domesticmouse suggested changes Oct 11, 2016

View reviewed changes

amyboyd force-pushed the fail-fast-over-limit branch from 842b5c6 to b9c263d Compare October 11, 2016 08:52

amyboyd added 2 commits October 11, 2016 09:53

Allow specific exception types to be retried or not retried.

5f55a2b

Document how to alter automatic retries.

dfbb9de

amyboyd force-pushed the fail-fast-over-limit branch from b9c263d to dfbb9de Compare October 11, 2016 08:54

domesticmouse approved these changes Oct 11, 2016

View reviewed changes

domesticmouse merged commit 4a8bc4c into googlemaps:master Oct 11, 2016

domesticmouse mentioned this pull request Oct 11, 2016

Add option to not retry once daily limit has been reached #168

Closed

Conversation

amyboyd commented Oct 9, 2016

Uh oh!

googlebot commented Oct 9, 2016

Uh oh!

amyboyd commented Oct 9, 2016

Uh oh!

domesticmouse commented Oct 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

domesticmouse left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants