➰ fixed long-running threads

[markmcd]

PTAL @broady @domesticmouse

I did some testing using a very basic sample app and it wasn't closing after main() finished. This changed value is passed to setDaemon(), so the thread should be closed.

[broady]

Hmmm — we don't really need this for the async requests, just the sync ones, right?

But to make that happen, we'd need two ExecutorService objects, yeah?

[markmcd]

Not sure I understand. Sync requests are turned into async requests and we just block until they're finished, so this is used for both.

Or do you mean we shouldn't daemonize requests that are executed async? We could parameterise the daemon flag and set based on async or not...

[broady]

Or do you mean we shouldn't daemonize requests that are executed async? We could parameterise the daemon flag and set based on async or not...

Correct. I don't think we can parameterise it though, since it's set when RateLimitExecutorService is constructed. Let's leave as-is for now, but just add a comment with an explanation.

[markmcd]

Done.

[broady]

I just noticed the Util class is under okhttp.internal. Can we just copy and paste it so we're not using an internal class?

[markmcd]

Done.

[broady]

dd

[broady]

LGTM!!