Skip to content

Fixing concurrency problem#255

Merged
domesticmouse merged 3 commits intogooglemaps:masterfrom
nbluis:master
Apr 5, 2017
Merged

Fixing concurrency problem#255
domesticmouse merged 3 commits intogooglemaps:masterfrom
nbluis:master

Conversation

@nbluis
Copy link
Copy Markdown
Contributor

@nbluis nbluis commented Mar 31, 2017

Fixes #254.

I decided to use the clone strategy to maintain compatibility with the current exception handling for NoSuchAlgorithmException and InvalidKeyException on UrlSigner creation.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nbluis nbluis changed the title Fixing concurrency problem #254 Fixing concurrency problem Mar 31, 2017
@nbluis
Copy link
Copy Markdown
Contributor Author

nbluis commented Mar 31, 2017

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@domesticmouse domesticmouse merged commit a8e19cc into googlemaps:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants