Conversation
Migrating google-maps-services-java to OkHttp3.
| requestHandler.setProxy(proxy == null ? Proxy.NO_PROXY : proxy); | ||
| return this; | ||
| /** | ||
| * Disable retries completely. |
There was a problem hiding this comment.
you might note that this clears the time limit and retries.
My 2c: I find this method a bit hard to grok. Setting retries to zero should be just as effective (even with e.g., a ten hour timeout)—can we just get users to do that?
There was a problem hiding this comment.
JavaDoc made more explicit as to the actions of the method.
| public double speedLimit; | ||
|
|
||
| /** Returns the speed limit in miles per hour (MPH). */ | ||
| /** @return Returns the speed limit in miles per hour (MPH). */ |
There was a problem hiding this comment.
Should you rephrase this now?
@return The speed limit in freedom units (MPH).
I mean, just drop the 'Returns'.
There was a problem hiding this comment.
I've always written JavaDoc with Returns as the first word of the @return line, because the generated JavaDoc reads a tad weird without it. Or at least it did back in the 1.4 days...
samthor
left a comment
samthor
left a comment
There was a problem hiding this comment.
LGTM but maybe we should chat about the nits
2 participants
No description provided.