Upgrade mockwebserver to 3.8.1 from OkHttp distribution#301
Upgrade mockwebserver to 3.8.1 from OkHttp distribution#301domesticmouse merged 1 commit intogooglemaps:masterfrom apjanke:mockwebserver-from-okhttp
Conversation
|
Can you please run |
This upgrades from the old standalone mockwebserver to the new one that's folded in to OkHttp.
|
I manually amended the code to comply with the format check, based on my reading of Google's Java Style Guide section on Also rebased on When I run Do I need to install some other library or something to get this to work? I read the build instructions, and don't see anything that looks relevant. |
|
Whacky. I'll land this PR as is and fix up any issues. Thanks! |
|
You're welcome. And thanks! |
|
Oh, my problem is obvious now: It's |
This library uses an old version of
mockwebserverfrom back when it was a standalone project. It has since been folded in to OkHttp, which this project also uses. The newmockwebserveris atcom.squareup.okhttp3:mockwebserver:3.8.1.From their old Google Code website:
Shall we upgrade to the new version from OkHttp? It looks like this project is keeping current on all its other dependencies.
This PR accomplishes the upgrade by changing the
mockwebserverdependency to the newcom.squareup.okhttp3:mockwebserver:3.8.1one, and updating the code to handle themockwebserverAPI changes between 20130706 and 3.8.1.Tests pass locally for me.