Skip to content

Update build.gradle - Changed guava to v20#308

Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom
gabrielsalmeida:patch-2
Aug 7, 2017
Merged

Update build.gradle - Changed guava to v20#308
domesticmouse merged 1 commit intogooglemaps:masterfrom
gabrielsalmeida:patch-2

Conversation

@gabrielsalmeida
Copy link
Copy Markdown
Contributor

com.google.guava:guava v22 require JDK 8, changing to guava v20 makes it compatible with JDK 7+.

com.google.guava:guava v22 require JDK 8, changing to guava v20 makes it compatible with JDK 7+.
@domesticmouse
Copy link
Copy Markdown
Contributor

Sorry to be a pain, but as I have written elsewhere the best way to access the Google Maps Web Services is either via the Places API for Android or via a Server based proxy, which can then utilise one of our Client Libraries, of which this is proudly one.

The reason for requiring this indirection is that embedding the API key for using the Google Maps Web Services into a mobile app, be it Android or iOS opens you up to API key theft. We'd much prefer that not to happen.

Thanks!

@domesticmouse
Copy link
Copy Markdown
Contributor

Actually, now that I've written that, there are valid use cases for using this library with Java7 in production, so I'll land this PR. But still, please don't use this library in Android. =)

@domesticmouse domesticmouse reopened this Aug 7, 2017
@domesticmouse domesticmouse merged commit 5818121 into googlemaps:master Aug 7, 2017
@gabrielsalmeida
Copy link
Copy Markdown
Contributor Author

Don't worry, I'm not using that for the mobile. I raised that, because I was having problems to make Objectify work with Java 8 runtime (I will check what can be done there to make it compatible).

@domesticmouse
Copy link
Copy Markdown
Contributor

Ahh cool. I'll roll a v0.2.2 release next week to publish this change. Thanks for understanding!

@apjanke
Copy link
Copy Markdown
Contributor

apjanke commented Aug 8, 2017

Just another data point: I am using google-maps-services-java with Java 7 in production, and will be for at least another six months. It's being used in a server-side application written in Matlab and using Matlab's embedded JVM, which is currently still on Java 7. I think this counts as one of those valid use cases.

@domesticmouse
Copy link
Copy Markdown
Contributor

I'll roll this fix out soon =)

This was referenced Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants