added java.io.Serializable to the response model #366#367
added java.io.Serializable to the response model #366#367domesticmouse merged 2 commits intogooglemaps:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
| public class AddressComponent { | ||
| public class AddressComponent implements Serializable { | ||
| /** The default serialVersionUID */ | ||
| private static final long serialVersionUID = 1L; |
There was a problem hiding this comment.
I think this is fine. It only mattered if AddressComponent was previously Serializable, which was not.
FWIW, my limited reading suggests that the reason most serialVersionUID fields are random super high numbers is that IDEs will create them using the previous default Java hashing implementation. But again, as the class was never serializable, anything is fine here.
There was a problem hiding this comment.
Thanks Sam, I concur.
| */ | ||
| public class AddressComponent { | ||
| public class AddressComponent implements Serializable { | ||
| /** The default serialVersionUID */ |
There was a problem hiding this comment.
I think this comment is probably redundant (on all classes).
There was a problem hiding this comment.
Thanks Sam, I concur but as this was the first time we introduce Serializable, I thought that this comment was neccessary. But I also agree with you that probably it's redundant in every class.
Should I delete them before you aprobed this pull request?
I tried to make real notice that that field was introduced for the serializable interface
There was a problem hiding this comment.
@lfochi please remove, and then I'll merge. Thanks!
|
Thanks @lfochi ! |
This is a pull request for issue #366