Suppress unchecked warning in GeoApiContextTest#372
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Nov 13, 2017
apjanke:suppress-unchecked-warning
Merged
Suppress unchecked warning in GeoApiContextTest#372domesticmouse merged 1 commit intogooglemaps:masterfrom apjanke:suppress-unchecked-warning
domesticmouse merged 1 commit intogooglemaps:masterfrom
apjanke:suppress-unchecked-warning
Conversation
Contributor
|
Sounds reasonable to me. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think about suppressing this unchecked-conversion warning in the GeoApiContextTest? Since it's just in a test using mock objects, I think that'd be acceptable.
When compiling now, I get this "note" output from the test compilation step.
With
-Xlint:uncheckedon:I've taken a stab at it, and I can't figure out how to wrangle the types to get it to compile without the warning, while using the dynamic
getClass()off the mockedApiResponseobject.This codebase is pretty close to a warning-clean build; this gets one step closer.