Skip to content

AddressType: add shoe_store#381

Merged
domesticmouse merged 2 commits intogooglemaps:masterfrom
apjanke:add-shoe-store
Nov 14, 2017
Merged

AddressType: add shoe_store#381
domesticmouse merged 2 commits intogooglemaps:masterfrom
apjanke:add-shoe-store

Conversation

@apjanke
Copy link
Copy Markdown
Contributor

@apjanke apjanke commented Nov 13, 2017

This PR adds the shoe_store AddressType.

Before: Produces warning:

$ ./bin/gmsj-cli geocode "bucket shoe store"
[main] WARN com.google.maps.internal.SafeEnumAdapter - Unknown type for enum com.google.maps.model.AddressType: 'shoe_store'
Results length: 1
Result 0:
Formatted Address: 1924 8th St NW, Washington, DC 20001, USA
Types: establishment / point_of_interest / unknown / store
PlaceId: ChIJ8cLMP-W3t4kRHrH3_aZWIx0

After: No warning:

$ ./bin/gmsj-cli geocode "bucket shoe store"
Results length: 1
Result 0:
Formatted Address: 1924 8th St NW, Washington, DC 20001, USA
Types: establishment / point_of_interest / shoe_store / store
PlaceId: ChIJ8cLMP-W3t4kRHrH3_aZWIx0

@domesticmouse
Copy link
Copy Markdown
Contributor

Ping

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@domesticmouse domesticmouse merged commit dc774e5 into googlemaps:master Nov 14, 2017
@domesticmouse
Copy link
Copy Markdown
Contributor

The other committer in this PR is me, one of the project maintainers - cleaning up a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants