Skip to content

AddressType: add travel_agency#382

Merged
domesticmouse merged 3 commits intogooglemaps:masterfrom
apjanke:add-travel-agency
Nov 14, 2017
Merged

AddressType: add travel_agency#382
domesticmouse merged 3 commits intogooglemaps:masterfrom
apjanke:add-travel-agency

Conversation

@apjanke
Copy link
Copy Markdown
Contributor

@apjanke apjanke commented Nov 13, 2017

This PR adds the travel_agency AddressType.

Before:

$ ./bin/gmsj-cli geocode "wherever"
[main] WARN com.google.maps.internal.SafeEnumAdapter - Unknown type for enum com.google.maps.model.AddressType: 'travel_agency'
Results length: 1
Result 0:
Formatted Address: 440 S Main St, Milltown, NJ 08850, USA
[...]

After:

$ ./bin/gmsj-cli geocode "wherever"
Results length: 1
Result 0:
Formatted Address: 440 S Main St, Milltown, NJ 08850, USA
Types: establishment / point_of_interest / travel_agency
[...]

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@domesticmouse
Copy link
Copy Markdown
Contributor

Cleaning up merge conflicts.

@domesticmouse domesticmouse merged commit 1a91b9b into googlemaps:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants