close response on retry

[esetnik]

This fixes the issue reported in #179

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[esetnik]

I signed it!

[googlebot]

CLAs look good, thanks!

[esetnik]

I've been running the alternative version in our production codebase for the last two weeks without a recurrence of #179

According to the ResponseBody documentation

For synchronous calls, the easiest way to make sure a response body is closed is with a try block. With this structure the compiler inserts an implicit finally clause that calls close() for you.

   

   Call call = client.newCall(request);
   try (Response response = call.execute()) {
     ... // Use the response.
   }

Which is closed on https://github.com/googlemaps/google-maps-services-java/blob/master/src/main/java/com/google/maps/internal/OkHttpPendingResult.java#L225. But if the code short circuits due to shouldRetry(response) returning true, then the response is never closed.

[domesticmouse]

Good catch, thanks!