Add more AddressTypes and AddressComponentTypes#437
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Jun 30, 2018
apjanke:more-location-types-3
Merged
Add more AddressTypes and AddressComponentTypes#437domesticmouse merged 1 commit intogooglemaps:masterfrom apjanke:more-location-types-3
domesticmouse merged 1 commit intogooglemaps:masterfrom
apjanke:more-location-types-3
Conversation
Contributor
|
I get the feeling I am going to break your PRs each time I merge one. Do you want to collapse all the location type addition PRs into a single PR? |
This was referenced Jun 30, 2018
Contributor
Author
|
Sure. I have merged all my outstanding location type PRs into this one, and rebased it on master. Looks like the merge is clean now. |
Contributor
Author
|
Hold on, don't merge this yet: got a failing unit test in com.google.maps.model.EnumsTest. Fixing... |
AddressTypes: * general_contractor AddressComponentTypes: * travel_agency * electronics_store * home_goods_store * school * store * art_gallery * lawyer * restaurant * bar * meal_takeaway * clothing_store * local_government_office * finance * moving_company * storage * cafe * car_repair * health * insurance_agency * painter
Contributor
Author
|
Unit test is fixed (including a fix for the failure introduced by #436). This is good to merge now, I think. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more currently-unrecognized AddressComponentTypes and AddressTypes.
AddressTypes:
AddressComponentTypes:
These were discovered using my gmsj-cli fuzz tester.