Have OkHttpRequestHandler evict connectionPool on shutdown#455
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Jul 3, 2018
apjanke:tidy-up-okhttp-client
Merged
Have OkHttpRequestHandler evict connectionPool on shutdown#455domesticmouse merged 1 commit intogooglemaps:masterfrom apjanke:tidy-up-okhttp-client
domesticmouse merged 1 commit intogooglemaps:masterfrom
apjanke:tidy-up-okhttp-client
Conversation
This is a minor optimization to support clients that are "doing the wrong thing" and creating many GeoApiContext objects. It somewhat reduces thread and memory pressure in that situation, and makes applications easier to monitor in tools like VisualVM.
domesticmouse
approved these changes
Jul 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor optimization to support clients that are "doing the wrong thing" and creating many GeoApiContext objects. It somewhat reduces thread and memory pressure in that situation, and makes applications easier to monitor in tools like VisualVM.
Without this patch, in my testing, OkHttpWorker threads accumulate up to about 800 threads before leveling off, with several threads appearing per new GeoApiContext object. With this patch, the growth is slower, and steady state levels off at about 300 threads.
This is not a critical fix; just a nicety for some users.
Follows up discussion in #261.