Remove Radar Search support#469
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Jul 9, 2018
apjanke:remove-radar-queries
Merged
Remove Radar Search support#469domesticmouse merged 1 commit intogooglemaps:masterfrom apjanke:remove-radar-queries
domesticmouse merged 1 commit intogooglemaps:masterfrom
apjanke:remove-radar-queries
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now past the June 30, 2018 deadline for Radar search being turned off, as per https://developers.google.com/places/web-service/search#RadarSearchRequests. Shall we remove support for it?
One hitch: while the
PlacesApi.radarSearchQuery(...)method was marked as deprecated in Javadoc a year ago, the method itself was not annotated as deprecated, andcom.google.maps.RadarSearchRequestwas not marked as deprecated either way, so this may be a bit of a surprise for some users. I say we roll with it though, since the Radar API service itself is turned off, so anything using these queries is hard broken anyway.