Change *RequestHandler Builder signatures to do chainable calls#470
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom Jul 9, 2018
apjanke:chainable-builder-signature
Merged
Change *RequestHandler Builder signatures to do chainable calls#470domesticmouse merged 1 commit intogooglemaps:masterfrom apjanke:chainable-builder-signature
domesticmouse merged 1 commit intogooglemaps:masterfrom
apjanke:chainable-builder-signature
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most Builder Pattern objects have their setters return
thisso calls are chainable. GeoApiContext.RequestHandler.Builder and its concrete implementations do not do this; they returnvoidinstead.This seems like just an oversight to me; I don't see a technical reason for them not to be chainable.
This PR changes GeoApiContext.RequestHandler.Builder and its concrete subclasses to return
thisfrom its setter methods, so calls on them are chainable.