Validate TextSearchRequest without query if type is set#566
Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom May 2, 2019
danoscarmike:master
Merged
Validate TextSearchRequest without query if type is set#566domesticmouse merged 1 commit intogooglemaps:masterfrom danoscarmike:master
domesticmouse merged 1 commit intogooglemaps:masterfrom
danoscarmike:master
Conversation
domesticmouse
suggested changes
May 1, 2019
Contributor
domesticmouse
left a comment
There was a problem hiding this comment.
Please add a test 😉
Contributor
Author
|
I actually started to write one but then realized there is no obvious existing test class file in which to put it. Happy to create one but I'm wondering if instead we should overload the PlacesApi.textSearchQuery method with something like: public static TextSearchRequest textSearchQuery(GeoApiContext context, PlaceType type) {
TextSearchRequest request = new TextSearchRequest(context);
request.type(type);
return request;
}Could easily extend existing tests then. WDYT? |
Contributor
|
I think I'll think about this after I/O =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated logic in
validateRequestmethod ofTextSearchRequestclassFixes #564