Skip to content

Fix: Format java files that break tests using gradlew check#573

Merged
domesticmouse merged 1 commit intogooglemaps:masterfrom
grant:grant_fix_tests
May 24, 2019
Merged

Fix: Format java files that break tests using gradlew check#573
domesticmouse merged 1 commit intogooglemaps:masterfrom
grant:grant_fix_tests

Conversation

@grant
Copy link
Copy Markdown
Contributor

@grant grant commented May 22, 2019

Fixes the broken Travis tests by ensuring ./gradlew check passes.

Logs

./gradlew check

> Task :test
objc[56081]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/bin/java (0x10ccbf4c0) and /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre/lib/libinstrument.dylib (0x10cd434e0). One of the two will be used. Which one is undefined.

> Task :verifyGoogleJavaFormat FAILED


The following files are not formatted properly:

/Users/timmerman/Documents/github/grant/google-maps-services-java/src/test/java/com/google/maps/PlacesApiTest.java
/Users/timmerman/Documents/github/grant/google-maps-services-java/src/main/java/com/google/maps/TextSearchRequest.java
/Users/timmerman/Documents/github/grant/google-maps-services-java/src/main/java/com/google/maps/model/PlacesSearchResult.java

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':verifyGoogleJavaFormat'.
> Problems: formatting style violations

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 31s
6 actionable tasks: 6 executed
timmerman @ ⎇ (grant_fix_tests) ~/Documents/github/grant/google-maps-services-java
❤ ./gradlew check

> Task :test
objc[56668]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/bin/java (0x1072354c0) and /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre/lib/libinstrument.dylib (0x1072b94e0). One of the two will be used. Which one is undefined.

BUILD SUCCESSFUL in 31s
6 actionable tasks: 5 executed, 1 up-to-date
timmerman @ ⎇ (grant_fix_tests) ~/Documents/github/grant/google-maps-services-java

Observe FAILURE -> BUILD SUCCESSFUL.

CC: @domesticmouse

@domesticmouse domesticmouse merged commit eddbd44 into googlemaps:master May 24, 2019
@domesticmouse
Copy link
Copy Markdown
Contributor

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants