Making serializable PlusCode#591
Merged
amuramoto merged 1 commit intogooglemaps:masterfrom Aug 27, 2019
despegar:master
Merged
Conversation
Member
|
Thanks for the PR! Can you explain the purpose of it/why change this to implement serializable? |
Contributor
Author
|
Sure! I am working on a feature about PlaceDetails API and I have to
serialize the response of the service. When I use this API, I get an object
of type PlaceDetails that is fully serializable, except for the "plusCode"
property. For that reason, I make the PlusCode class serializable; thus,
the response object (PlaceDetails) can be serialized without problems.
Regards!
…On Tue, Aug 27, 2019 at 2:38 PM Alex Muramoto ***@***.***> wrote:
Thanks for the PR! Can you explain the purpose of it/why change this to
implement serializable?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#591?email_source=notifications&email_token=AMOAEYVTQ3AFGFFEEABABALQGVRC5A5CNFSM4IQEV33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IRGJA#issuecomment-525407012>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMOAEYWDSRBSSPBCXZYVYTLQGVRC5ANCNFSM4IQEV33A>
.
|
Member
|
sgtm thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.