Set up tests to run with client ID too#7
Merged
broady merged 4 commits intogooglemaps:masterfrom Aug 22, 2014
markmcd:enterprise
Merged
Set up tests to run with client ID too#7broady merged 4 commits intogooglemaps:masterfrom markmcd:enterprise
broady merged 4 commits intogooglemaps:masterfrom
markmcd:enterprise
Conversation
Contributor
There was a problem hiding this comment.
The Parameterized stuff seems a bit overkill. Can we just call this "BaseSomethingTest" and add a getter for the context with the logic you have already?
Or even just a util class with a static function, if we want to avoid base test classes (better, IMO)
Contributor
Author
There was a problem hiding this comment.
As discussed IRL, I've updated the commentary to describe what's happening.
broady
added a commit
that referenced
this pull request
Aug 22, 2014
Set up tests to run with client ID too
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to comfortably tick off the enterprise signing support requirement.
PTAL @domesticmouse @broady