Skip to content

Add transit details#72

Merged
markmcd merged 5 commits intogooglemaps:masterfrom
NicolasPoirier:add-transit-details
Feb 26, 2015
Merged

Add transit details#72
markmcd merged 5 commits intogooglemaps:masterfrom
NicolasPoirier:add-transit-details

Conversation

@NicolasPoirier
Copy link
Copy Markdown
Contributor

Add transit details based on documentation.

@markmcd
Copy link
Copy Markdown
Contributor

markmcd commented Feb 24, 2015

A couple of quick comments. Firstly, thanks for the PR!

Can you please include the Apache license headers in each new file? And can you add some integration tests in here too? You can probably get away with just a single test that executes a transit request and prods a couple of your newly-added fields. See DirectionsApiTest.java

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is numStops.

@NicolasPoirier
Copy link
Copy Markdown
Contributor Author

Thanks for your feedback. I'm working on it.

About the Apache licence headers, do I add :

/*
* Copyright 2014 Google Inc. All rights reserved.
*
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this
* file except in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under
* the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
* ANY KIND, either express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

or do I have to remove Copyright 2014 Google Inc. All rights reserved. ?

@markmcd
Copy link
Copy Markdown
Contributor

markmcd commented Feb 24, 2015

Under the CLA you've signed, you retain copyright but also grant that license to Google. So you're more than welcome to use your own copyright line, or for consistency with the rest of the project, use "Copyright 2015 Google Inc. All rights reserved."

@NicolasPoirier
Copy link
Copy Markdown
Contributor Author

Typos have been fixed, Apache licence headers have been added and I added a test on transit details.

@markmcd
Copy link
Copy Markdown
Contributor

markmcd commented Feb 26, 2015

LGTM

markmcd added a commit that referenced this pull request Feb 26, 2015
@markmcd markmcd merged commit 5dda314 into googlemaps:master Feb 26, 2015
@NicolasPoirier
Copy link
Copy Markdown
Contributor Author

Could you add me in CONTRIBUTORS and AUTHORS files?

@markmcd
Copy link
Copy Markdown
Contributor

markmcd commented Mar 8, 2015

Oh! Apologies for missing you! That's done now (835fd60). Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants