Conversation
|
A couple of quick comments. Firstly, thanks for the PR! Can you please include the Apache license headers in each new file? And can you add some integration tests in here too? You can probably get away with just a single test that executes a transit request and prods a couple of your newly-added fields. See DirectionsApiTest.java |
|
Thanks for your feedback. I'm working on it. About the Apache licence headers, do I add : or do I have to remove |
|
Under the CLA you've signed, you retain copyright but also grant that license to Google. So you're more than welcome to use your own copyright line, or for consistency with the rest of the project, use "Copyright 2015 Google Inc. All rights reserved." |
|
Typos have been fixed, Apache licence headers have been added and I added a test on transit details. |
|
LGTM |
|
Could you add me in CONTRIBUTORS and AUTHORS files? |
|
Oh! Apologies for missing you! That's done now (835fd60). Thanks again for your contribution. |
Add transit details based on documentation.