Added some returning but not documented AddressType.#78
Merged
markmcd merged 6 commits intogooglemaps:masterfrom Mar 6, 2015
onlyonce:master
Merged
Added some returning but not documented AddressType.#78markmcd merged 6 commits intogooglemaps:masterfrom onlyonce:master
markmcd merged 6 commits intogooglemaps:masterfrom
onlyonce:master
Conversation
added 3 commits
February 28, 2015 18:29
The enum values stored in map. Not reguired to append in the lookup method. Added some address type.
Added generalized serialVersionUID. Logger varaibales are static. Added missing @OverRide. etc
Author
|
OK! I've missed the log in the AddressType. |
Contributor
There was a problem hiding this comment.
"Some addresses contain additional place categories."
While you're in here, would you mind fixing the typo on line 27 too? "The Adress types" should read "The address types"
Contributor
|
LGTM - @markmcd want to take a final look? |
Contributor
There was a problem hiding this comment.
Just a small one. As before - this first sentence should read: "Some addresses contain additional place categories."
Contributor
|
LGTM! |
markmcd
added a commit
that referenced
this pull request
Mar 6, 2015
Added some returning but not documented AddressType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some returning but not documented AddressType from https://developers.google.com/places/documentation/supported_types, and optimized the lookup method.
I've made some basic coding style corrections (add serialVersionUID; logger variables be static, etc).