Merged
Conversation
Contributor
markmcd
commented
Jun 14, 2015
markmcd
commented
- FareAdapter was failing when it hit unknown keys
- A directions API test with transit details was failing due to unexpected test data
Change-Id: If9671f64b832cd5cfe52a0c81fe6136e9e082db5
Change-Id: I8f7318ca27f92e7fe03aa5fa6d97dff0e0ccd00b
Contributor
Author
|
PTAL @domesticmouse and/or @samthor |
Contributor
There was a problem hiding this comment.
Just write this out: look for the transitIndex, or something.
int transitIndex = -1;
for (int i = 0; i < testLeg.steps.length; ++i) {
if (...) {
transitIndex = i;
break;
}
}
assertNotEqual(transitIndex, -1, ...);Change-Id: I22fa930cfa7e5bf9dbc6ce6ce7773918d87322a5
Contributor
Contributor
|
Post-hummus LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.