Skip to content

Conversation

@eegli
Copy link
Contributor

@eegli eegli commented Dec 2, 2021

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #141 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2021
"prepare": "rm -rf dist && rollup -c",
"test": "jest src/*"
"test": "jest src/*",
"test:watch": "jest --watch src/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm test -- --watch would be equivalent

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #146 (1899ce9) into main (eb3f4db) will increase coverage by 0.87%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   42.29%   43.17%   +0.87%     
==========================================
  Files          17       18       +1     
  Lines         383      410      +27     
  Branches        3        2       -1     
==========================================
+ Hits          162      177      +15     
- Misses        221      233      +12     
Impacted Files Coverage Δ
src/data.feature.ts 45.45% <45.45%> (ø)
src/data.ts 43.54% <100.00%> (+2.87%) ⬆️
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3f4db...1899ce9. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 2ae2ff2 into googlemaps:main Dec 2, 2021
@jpoehnelt
Copy link
Contributor

Thanks!

@eegli eegli deleted the feature/feature-mocks branch December 2, 2021 18:41
github-actions bot pushed a commit that referenced this pull request Dec 8, 2021
## [1.5.0](v1.4.0...v1.5.0) (2021-12-08)

### Features

* Add google.maps.Data.Feature mocks ([#146](#146)) ([2ae2ff2](2ae2ff2))

### Miscellaneous Chores

* **deps-dev:** bump @types/google.maps from 3.47.0 to 3.47.1 ([#150](#150)) ([f1f079a](f1f079a))
* **deps-dev:** bump jest from 27.4.2 to 27.4.3 ([#145](#145)) ([eb3f4db](eb3f4db))
* **deps-dev:** bump prettier from 2.5.0 to 2.5.1 ([#148](#148)) ([ccb6378](ccb6378))
* **deps-dev:** bump ts-jest from 27.0.7 to 27.1.0 ([#147](#147)) ([10ad3ba](10ad3ba))
* Synced local '.eslintrc.json' with remote 'sync-files/js/.eslintrc.json' ([#149](#149)) ([ba0b734](ba0b734))
* Synced local '.github/' with remote 'sync-files/js/.github/' ([#151](#151)) ([af13385](af13385))
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mocks for google.maps.Data

2 participants