fix: return actual sv instance for map method #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
eegli
force-pushed
the
fix-map-sv-getter
branch
from
4a1c602 to
2358e17
Compare
Contributor
Author
|
@wangela somehow, the test workflow is not kicking in. Can we merge this? |
amuramoto
approved these changes
Mar 7, 2023
Member
|
Thanks for the PR @eegli ! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
* return sv instance for map method * fix: return actual sv instance for map method 6dacdb0
googlemaps-bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
### [2.16.1](v2.16.0...v2.16.1) (2023-03-08) ### Bug Fixes * return actual sv instance for map method ([#325](#325)) ([6dacdb0](6dacdb0))
Contributor
|
🎉 This PR is included in version 2.16.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google.maps.Map.getStreetView()now returns an actual (mock) instance of a Street View panorama.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #324 🦕