Skip to content

fix: add missing abs to calculation for relative latlng vector#93

Merged
jpoehnelt merged 2 commits intomainfrom
fix/latLngToVector3Relative
Sep 14, 2021
Merged

fix: add missing abs to calculation for relative latlng vector#93
jpoehnelt merged 2 commits intomainfrom
fix/latLngToVector3Relative

Conversation

@jpoehnelt
Copy link
Copy Markdown

@jpoehnelt jpoehnelt commented Sep 14, 2021

might also close #51

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 14, 2021

Codecov Report

Merging #93 (32f17fc) into main (36a81b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   64.89%   64.89%           
=======================================
  Files           2        2           
  Lines          94       94           
  Branches        9        9           
=======================================
  Hits           61       61           
  Misses         33       33           
Impacted Files Coverage Δ
src/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a81b5...32f17fc. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 585f7de into main Sep 14, 2021
@jpoehnelt jpoehnelt deleted the fix/latLngToVector3Relative branch September 14, 2021 17:36
github-actions Bot pushed a commit that referenced this pull request Sep 14, 2021
## [1.0.1](v1.0.0...v1.0.1) (2021-09-14)

### Bug Fixes

* add missing abs to calculation for relative latlng vector ([#93](#93)) ([585f7de](585f7de))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@googlemaps/js-three latLngToVector3 inconsistent on different hemispheres

1 participant