Skip to content

fix: typo in place review#201

Merged
jpoehnelt merged 2 commits intogooglemaps:mainfrom
zulu-caPWN:patch-1
Sep 7, 2021
Merged

fix: typo in place review#201
jpoehnelt merged 2 commits intogooglemaps:mainfrom
zulu-caPWN:patch-1

Conversation

@zulu-caPWN
Copy link
Copy Markdown
Contributor

original: this field may by empty
new: this field may be empty

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

original: this field may by empty
new: this field may be empty
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Sep 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 7, 2021
@zulu-caPWN
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 7, 2021
@zulu-caPWN
Copy link
Copy Markdown
Contributor Author

ready for review

@jpoehnelt jpoehnelt changed the title typo fix fix: typo in place review Sep 7, 2021
@jpoehnelt jpoehnelt merged commit 04e6465 into googlemaps:main Sep 7, 2021
@jpoehnelt
Copy link
Copy Markdown

Thanks!

github-actions Bot pushed a commit that referenced this pull request Sep 7, 2021
## [1.16.22](v1.16.21...v1.16.22) (2021-09-07)

### Bug Fixes

* typo in place review ([#201](#201)) ([04e6465](04e6465))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 7, 2021

🎉 This PR is included in version 1.16.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zulu-caPWN
Copy link
Copy Markdown
Contributor Author

zulu-caPWN commented Sep 7, 2021 via email

@jpoehnelt
Copy link
Copy Markdown

Thank you!

@zulu-caPWN, Do you mind answering a couple questions?

Where did you find this typo?

  1. OpenAPI Spec
  2. Documentation at https://developers.google.com/maps/...
  3. Postman Collection
  4. Other

Are you generating client or server libraries from the OpenAPI spec?

(Y/N)

@zulu-caPWN
Copy link
Copy Markdown
Contributor Author

zulu-caPWN commented Sep 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants