Skip to content

build: ignore dist and move update-dist to after PRs are merged#400

Merged
wangela merged 1 commit intomainfrom
wangela/dist
Nov 10, 2022
Merged

build: ignore dist and move update-dist to after PRs are merged#400
wangela merged 1 commit intomainfrom
wangela/dist

Conversation

@wangela
Copy link
Copy Markdown
Member

@wangela wangela commented Nov 9, 2022

We've been finding that update-dist results in merge conflicts if PRs are merged out of order or update-dist is forgotten during a PR.

This adds the dist folder to .gitignore and automatically runs update-dist after a PR is successfully merged.

@wangela wangela requested review from a team and willum070 November 9, 2022 23:32
@wangela wangela requested review from amuramoto and removed request for willum070 November 9, 2022 23:32
Copy link
Copy Markdown
Contributor

@sgilsonapigee sgilsonapigee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@wangela wangela merged commit 7c810d2 into main Nov 10, 2022
@wangela wangela deleted the wangela/dist branch November 10, 2022 00:44
@googlemaps-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants