Skip to content

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Aug 13, 2024

Fixes #20

Updates the package structure and dependencies to support latest version of the @googlemaps/react-native-navigation-sdk package.
Also adds /example/tools/backend project for easier setup for the backend servers for example purposes.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@jokerttu jokerttu changed the title Feat/support latest navigation sdk library feat!/support latest navigation sdk library Aug 13, 2024
@jokerttu jokerttu marked this pull request as ready for review August 13, 2024 16:23
@caio1985 caio1985 self-requested a review August 13, 2024 17:48
Copy link
Member

@caio1985 caio1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu

This comment was marked as resolved.

@jokerttu jokerttu changed the title feat!/support latest navigation sdk library feat/support latest navigation sdk library Aug 16, 2024
Copy link
Contributor

@ArturoSalazarB16 ArturoSalazarB16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please update the commit message according to the "feat: " format

@jokerttu jokerttu force-pushed the feat/support-latest-navigation-sdk-library branch from 4549fc7 to c943973 Compare August 20, 2024 10:09
@jokerttu jokerttu changed the title feat/support latest navigation sdk library feat!: support latest navigation sdk library Aug 20, 2024
revert minSdkVersion to 23
separate tests to own folder
fix mockito dependencies
@jokerttu jokerttu force-pushed the feat/support-latest-navigation-sdk-library branch from c943973 to 5143f2b Compare August 20, 2024 10:18
@jokerttu
Copy link
Contributor Author

jokerttu commented Aug 20, 2024

Let's please update the commit message according to the "feat: " format

@ArturoSalazarB16 changed PR title to start with feat!: as that should cause breaking change version update with release-please.
Also updated the package name, and tested the example apps that they still work.
As this PR is already approved, it can be merged if you see that the latest changes do not need reviewing.

@jokerttu jokerttu merged commit 057bb28 into main Aug 21, 2024
@jokerttu jokerttu deleted the feat/support-latest-navigation-sdk-library branch August 21, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support latest react-native-navigation-sdk package

3 participants