-
Notifications
You must be signed in to change notification settings - Fork 25
test: integration tests #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: integration tests #368
Conversation
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Run unit tests | ||
| run: yarn test --maxWorkers=2 --coverage | ||
| # test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This will be enabled in separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@illuminati1911
Looks already good.
Would like to have way to run the tests against release build. If current version is kept, the contribution.md document must tell that metro must be running when running tests.
See examples at:
https://github.com/wix/Detox/blob/e3393c7f62a68188808b6054b97608a84ec43cd1/examples/demo-react-native/README.md?plain=1#L37-L81
Also some tests (at least on iOS) fail quite ofter... this can be improved separately, but if these can be made more stable in this PR the better.
aafea99 to
c713881
Compare
jokerttu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works.
Sometimes tests are flaky, but this is quite usual when working with real world navigation (not mocked).
We will improve the test cases and stability in future PR:s.
LGTM
|
@ArturoSalazarB16 waiting final check from you |
cdf3241 to
0a99761
Compare
0a99761 to
99bc456
Compare
Adds integration tests to the project. For the tests detox is used along with example app implementation.