Skip to content

Conversation

@illuminati1911
Copy link
Contributor

@illuminati1911 illuminati1911 commented Dec 2, 2024

Adds integration tests to the project. For the tests detox is used along with example app implementation.

  • Tests pass
  • Appropriate changes to documentation are included in the PR


- name: Run unit tests
run: yarn test --maxWorkers=2 --coverage
# test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This will be enabled in separate PR

Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illuminati1911
Looks already good.
Would like to have way to run the tests against release build. If current version is kept, the contribution.md document must tell that metro must be running when running tests.
See examples at:
https://github.com/wix/Detox/blob/e3393c7f62a68188808b6054b97608a84ec43cd1/examples/demo-react-native/README.md?plain=1#L37-L81

Also some tests (at least on iOS) fail quite ofter... this can be improved separately, but if these can be made more stable in this PR the better.

@jokerttu jokerttu force-pushed the test/integration-tests branch from aafea99 to c713881 Compare December 5, 2024 13:33
@jokerttu jokerttu marked this pull request as ready for review December 5, 2024 13:47
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works.
Sometimes tests are flaky, but this is quite usual when working with real world navigation (not mocked).
We will improve the test cases and stability in future PR:s.

LGTM

@jokerttu
Copy link
Contributor

jokerttu commented Dec 9, 2024

@ArturoSalazarB16 waiting final check from you

@jokerttu jokerttu force-pushed the test/integration-tests branch 2 times, most recently from cdf3241 to 0a99761 Compare December 17, 2024 06:44
@jokerttu jokerttu force-pushed the test/integration-tests branch from 0a99761 to 99bc456 Compare December 17, 2024 06:55
@jokerttu jokerttu merged commit f611a43 into googlemaps:main Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants