feat(marker): add imageBase64 and anchor support#587
Open
esannihith wants to merge 1 commit intogooglemaps:mainfrom
Open
feat(marker): add imageBase64 and anchor support#587esannihith wants to merge 1 commit intogooglemaps:mainfrom
esannihith wants to merge 1 commit intogooglemaps:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom map markers and fixes #579.
Instead of passing an image URL and handling downloads natively, this approach adds an imageBase64 prop. It feels more natural for React Native since image fetching can stay in JS, while the native side only focuses on rendering.
Changes
-Added imageBase64 to MarkerOptions for Android and iOS
-Added anchor support ({u, v}) for properly centering custom markers like avatars
-Added an integration test in the example app to verify base64 marker rendering works correctly
Fixes #579
Pre-launch Checklist