Skip to content

Conversation

@Leo-Neat
Copy link

Allows test suites to be run for a definite number of times. The results are compiled and displayed to the user once the suite is finished running.

@Leo-Neat Leo-Neat requested a review from nic0lette May 29, 2020 21:56
Copy link
Member

@nic0lette nic0lette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor string thing then lgtm.

setContentView(R.layout.test_suite_configure_dialog)
title.text = testSuite.name + " Configuration"
subtitle.text = testSuite.description
title.text = testSuite.testSuiteName + " Configuration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to use a string template instead of concatenation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@Leo-Neat Leo-Neat merged commit a318d45 into googlesamples:master Jun 1, 2020
@Leo-Neat Leo-Neat deleted the iter branch June 1, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants