-
Notifications
You must be signed in to change notification settings - Fork 454
Closed
Description
After build npm run-script dist the next piece of code is not deleted
if (module) {
module.exports = {
createService: createService,
getRedirectUri: getRedirectUri
};
}
I'm not sure that it's the best way to use a undeclared variable. When I forget to remove it I catch ReferenceError: "module" is not defined. (line 64, file "OAuth2")
Should I pull a new request?
if (typeof module === 'object') {
module.exports = {
createService: createService,
getRedirectUri: getRedirectUri
};
}
Or is there any another way to automate this? I see there is not the code in the original library.
I use the distributive when there is no way to deliver as a library. It is very convenient.
Metadata
Metadata
Assignees
Labels
No labels