chore: Update dependencies + remove node fiber #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and breaks on current node versions
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
sqrrrl
changed the title
jpoehnelt
approved these changes
Aug 2, 2022
sqrrrl
added a commit
that referenced
this pull request
Aug 2, 2022
…and breaks on current node versions (#390)
sqrrrl
added a commit
that referenced
this pull request
Aug 4, 2022
…and breaks on current node versions (#390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates 3P packages to current versions and removes node-fiber. Node-fiber is no longer supported and is considered obsolete, and also causes node 16+ to crash. Rewrites a few tests + mocks to no longer depend on it.
Unfortunate side effect is the tests for locking aren't testing thread safety any more. It might be possible in the future to recreate apps script semantics via worker threads. For now, this relaxes the tests so builds aren't locked in to old versions of node.
Redo of #364