docs: add asdf installation instructions#296
docs: add asdf installation instructions#296sonwr wants to merge 5 commits intogoogleworkspace:mainfrom
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the installation documentation for the Google Workspace CLI by integrating Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds installation instructions for asdf to the README.md file. While adding more installation options is great, one of the provided commands is incorrect. I've suggested a correction to use the current, standard asdf command. Additionally, for user transparency and security, I've recommended clarifying that the asdf plugin is community-maintained.
|
Thanks for the review — great catches. I updated both points in 7405c01:
I also resolved both review threads. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds installation instructions for asdf. The change itself is straightforward, but it introduces a reference to a third-party, community-maintained plugin. My review includes a high-severity security comment recommending the addition of an explicit warning to mitigate potential supply chain risks associated with promoting a non-official plugin within a googleworkspace project.
|
Thanks — agreed on the supply-chain risk framing. I added an explicit warning block in README (commit 0ecda9d) clarifying that I also resolved the thread. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new installation option using asdf to the README.md. The instructions are clear and provide a good starting point for users who prefer this version manager. I have one suggestion to improve the reproducibility of the environment by pinning to a specific version instead of using a floating 'latest' tag, which can prevent unexpected breakages for users.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds instructions for installing the gws CLI using asdf. The changes are in the README.md file. My review focuses on the correctness and clarity of the provided commands. I've identified an issue where the instructions can be misleading if a user wants to install a specific version, and I've suggested a change to make the instructions clearer and more robust by separating the use cases for installing the latest versus a specific version.
|
Great point — fixed in follow-up commit 152f1c9.\n\nI split the asdf section into two explicit paths:\n- install/pin latest\n- install/pin a specific version\n\nThis avoids implying that should always set when a user intends to pin a specific version. |
|
Quick clarification (my previous comment lost inline code formatting): the ambiguity was around |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds installation instructions for asdf to the README.md file. The new section includes a warning about the community-maintained nature of the plugin and provides clear commands for installation. The changes are well-documented and I found no issues that meet the high or critical severity threshold requested for this review.
Adds an asdf installation option to the README Installation section, based on the plugin shared in #264.
Validation:
Closes #264