fix(setup): allow deselecting previously enabled APIs in gws auth setup#570
Open
haunchen wants to merge 1 commit intogoogleworkspace:mainfrom
Open
fix(setup): allow deselecting previously enabled APIs in gws auth setup#570haunchen wants to merge 1 commit intogoogleworkspace:mainfrom
gws auth setup#570haunchen wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
…tup` The API picker marked already-enabled APIs as `is_fixed: true`, preventing users from reducing their enabled API set. Now previously enabled APIs are pre-selected but toggleable. Deselected APIs are disabled via `gcloud services disable`. Closes googleworkspace#529
🦋 Changeset detectedLatest commit: 5ecdefc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gws auth setupmarks already-enabled APIs asis_fixed: truein the TUI picker, preventing users from deselecting them. This is a problem when:Changes:
is_fixed: already→is_fixed: falseso previously enabled APIs are pre-selected but toggleabledisable_apis()function (mirrorsenable_apis()) to disable deselected APIs viagcloud services disableapis_would_disableoutputCloses #529
Test plan
cargo clippy -- -D warnings— cleancargo test— 42 setup tests pass (including 4 new tests)test_pipeline_previously_enabled_can_be_deselected— verifies pre-selected items can be toggled offtest_disable_apis_with_no_apis— empty input returns empty resultstest_disable_apis_with_invalid_project— invalid project produces failure with error messagegws auth setupon a project with previously enabled APIs, deselect one, confirm it gets disabled