fix(auth): expose Gmail settings scope#817
Conversation
🦋 Changeset detectedLatest commit: 3ea3270 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Workspace CLI by exposing the 'gmail.settings.basic' scope, which is required for accessing specific Gmail settings endpoints like filters. The changes ensure this scope is available for advanced users while maintaining a conservative default for first-time logins. The implementation includes updated scope resolution logic and regression tests to ensure correct behavior during authentication flows. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the https://www.googleapis.com/auth/gmail.settings.basic scope to the Google Workspace CLI. The changes include adding the scope to the full authentication flow, defining it as redundant when the broader https://mail.google.com/ scope is present, and providing a corresponding label for the UI. Additionally, unit tests were added to ensure the scope is correctly handled during scope resolution and filtering. I have no feedback to provide as there were no review comments to evaluate.
Summary
https://www.googleapis.com/auth/gmail.settings.basicto the--fullauth scope sethttps://mail.google.com/is also present;gmail.modifyis intentionally not treated as a broader substituteThis refreshes #794 with the conservative scope design kept explicit. Gmail settings endpoints such as filters.list require
gmail.settings.basic: https://developers.google.com/workspace/gmail/api/reference/rest/v1/users.settings.filters/listTesting