Log an error when there is an issue exchanging the authorization code#23
Merged
erickoledadevrel merged 1 commit intomasterfrom Aug 6, 2018
Merged
Log an error when there is an issue exchanging the authorization code#23erickoledadevrel merged 1 commit intomasterfrom
erickoledadevrel merged 1 commit intomasterfrom
Conversation
grant
approved these changes
Aug 6, 2018
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
LGTM. Although, I'd leave off the \n changes if the lint tests pass without the changes.
erickoledadevrel
force-pushed
the
unhandledpromise
branch
from
71a1fcd to
ccf607b
Compare
Author
|
Ya, looks like it only allows no curly braces if it's a single line. Reduced the error message length so that it fits on one line. |
… for an access token.
erickoledadevrel
force-pushed
the
unhandledpromise
branch
from
ccf607b to
9a70563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.