Skip to content

[v2] Switch to a version of gocovmerge compatible with go 1.22#3325

Merged
EmilienM merged 1 commit intogophercloud:v2from
shiftstack:pin-goimports-v2
Mar 11, 2025
Merged

[v2] Switch to a version of gocovmerge compatible with go 1.22#3325
EmilienM merged 1 commit intogophercloud:v2from
shiftstack:pin-goimports-v2

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Mar 10, 2025

The original gocovmerge repository [1] has not seen a commit in 9 years and should be considered unmaintained.

Switch to fork has a go.mod pinned to go 1.22. Please review the diff [2] between the two repos to check if it's safe to use in gophercloud.

[1] https://github.com/wadey/gocovmerge
[2] wadey/gocovmerge@master...alexfalkowski:gocovmerge:v1.4.0

The original `gocovmerge` repository [1] has not seen a commit in 9 years
and should be considered unmaintained.

Switch to fork has a go.mod pinned to go 1.22. Please review the diff [2]
between the two repos to check if it's safe to use in gophercloud.

[1] https://github.com/wadey/gocovmerge
[2] wadey/gocovmerge@master...alexfalkowski:gocovmerge:v1.4.0
@github-actions github-actions bot added edit:actions This PR updates GitHub Actions code v2 This PR targets v2 edit:testinfra This PR updates testing infrastructure code semver:patch No API change labels Mar 10, 2025
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 78.732%. remained the same
when pulling 2a76f50 on shiftstack:pin-goimports-v2
into 98349c5 on gophercloud:v2.

@mandre mandre marked this pull request as ready for review March 10, 2025 09:42
@mandre mandre changed the title Switch to a version of gocovmerge compatible with go 1.22 [v2] Switch to a version of gocovmerge compatible with go 1.22 Mar 10, 2025
@EmilienM EmilienM requested a review from pierreprinetti March 10, 2025 14:23
@EmilienM EmilienM merged commit fe8ded1 into gophercloud:v2 Mar 11, 2025
18 checks passed
@EmilienM EmilienM deleted the pin-goimports-v2 branch March 11, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code semver:patch No API change v2 This PR targets v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants