Merged
Conversation
github-actions
bot
added
edit:networking
vydrazde
reviewed
Aug 12, 2025
| // NextPageURL is invoked when a paginated collection of Endpoint groups has | ||
| // reached the end of a page and the pager seeks to traverse over a new one. | ||
| // In order to do this, it needs to construct the next page's URL. | ||
| func (r TapMirrorPage) NextPageURL(endpointURL string) (string, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (r TapMirrorPage) NextPageURL(endpointURL string) (string, error) { | |
| func (r TapMirrorPage) NextPageURL() (string, error) { |
With this change the tests pass in my environment. @kayrus could you commit? I don't have the rights.
Contributor
There was a problem hiding this comment.
Right, the signature for NextPageURL() changed in main via 299f18c. I'll update the backport to use the right signature.
The signature for NextPageURL() changed in main via 299f18c which caused the backport to fail. Let's use the expected signature for v2 branch.
mandre
approved these changes
Aug 14, 2025
Contributor
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
The e2e tests succeeded now, however coveralls.io is down and this causes the unit tests to fail at the moment.
Contributor
|
Looks like coveralls.io is back up. |
mandre
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #3483
Closes #3482
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/tap-as-a-service/blob/7984544610ed949414967cfe950f18336fa21880/neutron_taas/db/tap_mirror_db.py#L82
https://github.com/openstack/tap-as-a-service/blob/7acc6654ecdffafb22e6ef9ad64606e0c902a722/neutron_taas/services/taas/drivers/linux/ovs_taas.py#L584
I am not sure how to best deal with the Directions. According to docs and unit tests the values of the Directions should be integers. However, using the python taas client with python openstack client from bash sets the values as strings. From my testing the taas accepts both
intandstras long as thestrcan be converted tointand saves thestrunchanged (eq '002' is valid and returned as '002'). To not fail when listing or showing Tap Mirrors created by the python client I set the type asstr, but I am open to suggestions.