Simplify kernel #45
Merged
Simplify kernel #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL simplifies and harmonizes the way 'gophernotes' is started from inside Jupyter. Just take it from $PATH instead of hard-coding some absolute path.
This CL fixes the display name of the Go kernel: Go is called Go, not Golang.
Member
Author
|
ping @dwhitena ? |
Contributor
|
Thanks @sbinet. Sorry for the delay. Was traveling. LGTM |
Member
Author
|
(no worries) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this CL modifies the default
kernel.jsonconfig file to not hard-code some path to thegophernotesexecutable. (tested on mybinder.org/repo/gopherds/mybinder-go)This CL also modifies the displayed name of the Go kernel: the language is called Go, not Golang :)