Code refactor: Refactor engine API#477
Merged
nighca merged 1 commit intogoplus:devfrom Dec 11, 2024
Merged
Conversation
Contributor
JiepengTan
commented
Dec 10, 2024
JiepengTan
commented
- Clarify main thread and non-main thread functions.
- Split the engine wrap code into an independent namespace.
- Delete useless functions.
- Use vectors to implement some algorithms.
![qiniu-x[bot]](https://avatars.githubusercontent.com/in/752628?s=60&v=4){kind=small}
JiepengTan
force-pushed
the
pr_code_refactor
branch
from
3a458d0 to
cb8a279
Compare
JiepengTan
force-pushed
the
pr_code_refactor
branch
from
cb8a279 to
616effd
Compare
nighca
reviewed
Dec 11, 2024
|
|
||
| type ProxySprite struct { | ||
| Sprite | ||
| // !!!Warning all method belong to this class can only be called in main thread |
Contributor
There was a problem hiding this comment.
Nit: To ensure developers always remember this when manipulating Sprite, we may use a specific prefix or suffix for related methods, such as UpdateTexture_MustFromMainThread. While it may look ugly, it could be beneficial. 🤣
nighca
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.