Fix stage's onClick event#583
Merged
JiepengTan merged 1 commit intogoplus:devfrom Apr 16, 2025
Merged
Conversation
JiepengTan
force-pushed
the
pr_fix_stage_on_click_event
branch
from
e5af232 to
70de1d6
Compare
nighca
previously approved these changes
Apr 16, 2025
nighca
reviewed
Apr 16, 2025
| } | ||
| } | ||
|
|
||
| if p.inputs.canTriggerClickEvent(inputStageClickTimerId) { |
Contributor
There was a problem hiding this comment.
What if some sprite is clicked (isClicked: true), while p.inputs.canTriggerClickEvent(syncSprite.GetId()) returns false because of inputMouseClickIntervalMs check? The stage-click will be triggered, which I think is not expected.
JiepengTan
force-pushed
the
pr_fix_stage_on_click_event
branch
from
70de1d6 to
b8d350e
Compare
nighca
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stage's onClick event should only be triggered when it is not occluded by any sprite
issue: #580
test project: match3.zip