qiniu/x v1.18.0#2750
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the line iteration logic in cl/_testgop/enumlines-rdr/out.go by replacing a custom iterator loop with a standard range-over-func loop. Additionally, it upgrades the github.com/qiniu/x dependency from version v1.17.0 to v1.18.0 in go.mod and go.sum. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR upgrades github.com/qiniu/x from v1.17.0 to v1.18.0 and includes several refactors. There are two important findings that need attention.
Summary
| Severity | File | Issue |
|---|---|---|
| 🔴 Critical | cmd/make.go, cmd/make_test.go |
Nil pointer dereference on non-ErrNotExist errors |
| 🟡 Important | printer/printer.go |
Removal of infinity guard changes boundary semantics; two related tests deleted |
| 🔵 Minor | .github/workflows/go.yml |
Codecov action downgraded from v7 to v6 without explanation |
Additional Note
.github/workflows/go.yml line 56: codecov/codecov-action was downgraded from @v7 to @v6. This is unusual — if v7 had a breaking change for this project, a comment in the workflow file explaining the reason would prevent future contributors from re-upgrading accidentally.
Findings without inline locations
cmd/make.go:38: Nil pointer dereference on non-ErrNotExisterrors 🔴cmd/make_test.go:30: Same nil pointer dereference ascmd/make.go🔴printer/printer.go:168: Semantic change:<=→<removes equal-offset comment support 🟡
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2750 +/- ##
==========================================
+ Coverage 94.09% 94.28% +0.18%
==========================================
Files 32 32
Lines 10074 10336 +262
==========================================
+ Hits 9479 9745 +266
+ Misses 425 421 -4
Partials 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
No description provided.