Skip to content

cl todo: _testnext/type-args-template-recv-mthd#2773

Merged
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q
Jun 21, 2026
Merged

cl todo: _testnext/type-args-template-recv-mthd#2773
xushiwei merged 1 commit into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test case type-args-template-recv-mthd in cl/_testnext that demonstrates a method call on a template receiver with type arguments. It also adds a disabled test function _TestTestnext in cl/compile_testdir_test.go to run this test case. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (4e80151) to head (912cbb2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2773   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          32       32           
  Lines       10147    10147           
=======================================
  Hits         9550     9550           
  Misses        427      427           
  Partials      170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xushiwei xushiwei merged commit ececfb3 into goplus:main Jun 21, 2026
11 checks passed

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a compile-only test fixture for the template-receiver-method feature and intentionally disables the test runner until the feature is implemented. The change is low-risk and consistent with the project's _TestTestjs precedent.

Two minor observations:

Indentation inconsistency in in.xgotypeargs.App on line 4 is indented with 4 spaces, while the app.onCall lambda body uses a tab. Go/XGo convention is tabs throughout; normalising line 4 would keep the fixture consistent.

Missing out.go — When out.go is absent cltest.FromDir silently skips the codegen-diff assertion and only verifies compilation. This is acceptable for a todo placeholder, but when the feature lands and _TestTestnext is re-enabled, an out.go should be added so the test actually asserts correct output.

View job run

import "github.com/goplus/xgo/cl/internal/typeargs"

type MyApp struct {
typeargs.App

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is indented with 4 spaces while the echo "onCall" body on line 13 uses a tab. Go/XGo convention is tabs throughout — consider normalising to a tab here for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant