Skip to content

cl: mv _testgop => _testxgo; add _testgo#2774

Merged
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:q
Jun 21, 2026
Merged

cl: mv _testgop => _testxgo; add _testgo#2774
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the test function TestTestgop to TestTestxgo and adds a disabled test _TestTestgo in cl/compile_testdir_test.go. It also introduces a new test file cl/_testgo/types/in.xgo. Feedback was provided regarding an unexported function call cmplx.sqrt in the new test file, which should be capitalized to cmplx.Sqrt to avoid compilation errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread cl/_testgo/types/in.xgo

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulk rename (_testgop_testxgo) and test-function updates are clean. Note: cmplx.sqrt in the new fixture is valid XGo — the language supports lowercase-first-letter calls to exported Go identifiers (same pattern as os.open, re.matchString in _testxgo), so that is not a bug.

Findings

CLAUDE.md:40 and CLAUDE.md:126 — stale directory references (not updated in this PR)

Two lines in CLAUDE.md still reference the old path cl/_testgop/ which no longer exists after this rename:

  • Line 40: "Testing: Add comprehensive test cases in cl/_testgop/ covering various usage scenarios"
  • Line 126: "Phase 2: Comprehensive test coverage for semantic implementation in cl/_testgop/ covering:"

Both should be updated to cl/_testxgo/.

View job run

Comment thread cl/compile_testdir_test.go
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (912cbb2) to head (9b5be53).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2774   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          32       32           
  Lines       10147    10147           
=======================================
  Hits         9550     9550           
  Misses        427      427           
  Partials      170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xushiwei xushiwei merged commit 9c68043 into goplus:main Jun 21, 2026
11 checks passed
@xushiwei xushiwei deleted the q branch June 21, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant