cl: mv _testgop => _testxgo; add _testgo#2774
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames the test function TestTestgop to TestTestxgo and adds a disabled test _TestTestgo in cl/compile_testdir_test.go. It also introduces a new test file cl/_testgo/types/in.xgo. Feedback was provided regarding an unexported function call cmplx.sqrt in the new test file, which should be capitalized to cmplx.Sqrt to avoid compilation errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
The bulk rename (_testgop → _testxgo) and test-function updates are clean. Note: cmplx.sqrt in the new fixture is valid XGo — the language supports lowercase-first-letter calls to exported Go identifiers (same pattern as os.open, re.matchString in _testxgo), so that is not a bug.
Findings
CLAUDE.md:40 and CLAUDE.md:126 — stale directory references (not updated in this PR)
Two lines in CLAUDE.md still reference the old path cl/_testgop/ which no longer exists after this rename:
- Line 40:
"Testing: Add comprehensive test cases in cl/_testgop/ covering various usage scenarios" - Line 126:
"Phase 2: Comprehensive test coverage for semantic implementation in cl/_testgop/ covering:"
Both should be updated to cl/_testxgo/.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 32 32
Lines 10147 10147
=======================================
Hits 9550 9550
Misses 427 427
Partials 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.