fix: process pool concurrency

[krishankumar01]

📑 Description

✅ Checks

• Added test cases for my code

[codecov]

Codecov Report

❌ Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.64%. Comparing base (632170c) to head (976dce2).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
process/pool.go	77.27%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
+ Coverage   70.60%   70.64%   +0.03%     
==========================================
  Files         286      286              
  Lines       17612    17665      +53     
==========================================
+ Hits        12435    12479      +44     
- Misses       4652     4658       +6     
- Partials      525      528       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[krishankumar01]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes refactor the process pool's concurrency model from per-job goroutine waiting to a collector pattern with a RunningPool abstraction, add thread-safety through mutexes in tests, introduce a new deprecated GetJson method to the Application type, and disable the Telemetry binding entry.

Changes

Cohort / File(s)	Summary
Binding Configuration contracts/binding/binding.go	Commented out Telemetry entry from exported Bindings map with a TODO note, effectively disabling it without removing other entries.
Foundation API Extensions foundation/application.go	Added new public method GetJson() returning foundation.Json, marked as deprecated with guidance to use Json() instead.
Process Pool Concurrency Refactoring process/pool.go, process/running_pool.go	Replaced per-job goroutine waiting with collector pattern and RunningPool abstraction. Pool workers now execute synchronously, pushing results to shared channel consumed by dedicated collector. RunningPool redesigned with mutex-protected maps for processes and results, new setProcess and setResult helpers, and simplified NewRunningPool signature.
Process Pool Unix Tests process/pool_unix_test.go, process/running_pool_unix_test.go	Added mutex synchronization in test callbacks for thread safety. Updated NewRunningPool call sites to match simplified constructor signature (6 parameters vs. 8, removed results map and placeholder nils).
Process Pool Windows Tests process/pool_windows_test.go, process/running_pool_windows_test.go	Added mutex protection around shared state in OnOutput callbacks. Introduced long-running PowerShell command (Start-Sleep -Seconds 10) in signal handling test with updated assertions for expected failure state.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~65 minutes

Poem

🐰 The pool now flows with ordered grace,
No goroutines race through this space,
A collector gathers results with care,
While mutexes guard our data fair,
RunningPool orchestrates the way,
Synchronized threads in perfect ballet! 🎭

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: process pool concurrency' accurately reflects the primary changes in the pull request, which focus on reworking the process pool's concurrency model and synchronization mechanisms.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hwbrzzl]

LGTM, could you add some screenshots for the local test?

[krishankumar01]

@hwbrzzl done

[hwbrzzl]

Awesome